[PATCH] D141867: [mlir][vector] Share enums with the transform dialect

Tue Jan 17 00:57:37 PST 2023

qcolombet marked 2 inline comments as done.
qcolombet added inline comments.

================
Comment at: mlir/include/mlir/Dialect/Vector/TransformOps/VectorTransformOps.td:54
+    (`split_transfers` `=` $split_transfers^)?
+    (`transpose_lowering` `=` $transpose_lowering^)?
+    attr-dict
----------------
nicolasvasilache wrote:
> qcolombet wrote:
> > We have to explicitly list all the fields here to have the proper parsing of the enums.
> > 
> > This may have an impact on the supported syntax. I.e., I don't know if `attr-dict` allows to put the attributes in whatever order, but if it does, then we lose this ability here.
> `attr-dict` allows any order and not enforcing a particular order indeed seems better.
> 
> Lookup oilist in the ODS doc, it does what you want here: https://mlir.llvm.org/docs/DefiningDialects/Operations/#directives
> 
Great!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141867/new/

https://reviews.llvm.org/D141867