[PATCH] D141823: [SCEV] More precise trip multiples

Mon Jan 16 23:12:21 PST 2023

caojoshua added a comment.

In D141823#4057047 <https://reviews.llvm.org/D141823#4057047>, @nikic wrote:

> In D141823#4056673 <https://reviews.llvm.org/D141823#4056673>, @caojoshua wrote:
>
>> In D141823#4055951 <https://reviews.llvm.org/D141823#4055951>, @nikic wrote:
>>
>>> Precommit tests please.
>>
>> What is precommit test? I've been running llvm-lit llvm/test
>
> Commit the new tests with baseline checks (without your patch), and then rebase on top, so it only shows diffs.

Thanks. I've done this for the newest revision. I see why this is preferable, but unless I think I'm missing something, this should be included somewhere in LLVM docs i.e. https://llvm.org/docs/CodeReview.html or https://llvm.org/docs/TestingGuide.html.

I have another question. When patches get approved, should owners squash the commits before pushing? Or push two separate commits.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141823/new/

https://reviews.llvm.org/D141823