[PATCH] D141834: [RISCV][NFC] Use uncompressInst to relax instructions

Kito Cheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 16 22:58:26 PST 2023


kito-cheng added inline comments.


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVAsmBackend.cpp:183
+    bool Success = uncompressInst(Res, Inst, MRI, STI);
+    assert(Success && "Can't uncompress instruction");
     break;
----------------
Another nit, you need add `(void)Success;` to suppress unused variable warning for disable assertion build.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141834/new/

https://reviews.llvm.org/D141834



More information about the llvm-commits mailing list