[PATCH] D141891: [VP][DAGCombiner] Introduce gneralized pattern match for vp sdnodes.
Yeting Kuo via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 16 22:07:36 PST 2023
fakepaper56 added a comment.
@simoll There is some difference between my implement and yours:
1. Operand with true mask does not fail in `match()` of `VPMatchContext`.
2. Operand with normal opcode does not fail in `match()` of `VPMatchContext` if its opcode is same as the input opcode.
3. Make `VPMatchContext` be only constructed by vp root nodes. It could help for point 2.
4. I removed the member function `getFunctionOpCode` and `isCompatible`.
Do you have any idea for my change?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141891/new/
https://reviews.llvm.org/D141891
More information about the llvm-commits
mailing list