[PATCH] D141865: [llvm][GenericUniformity] Hack around strict is_invocable() checks

[Sameer Sahasrabuddhe via Phabricator via llvm-commits]

sameerds added a comment.

Thanks for figuring this out! I just have a problem with the template parameter name "DelT", which should be easy to fix.



================
Comment at: llvm/include/llvm/ADT/GenericUniformityInfo.h:70
+  // whether or not the type of ImplT is spelled out.
+  template <typename DelT = ImplT> struct ImplDeleter {
+    void operator()(DelT *Impl);
----------------
Is the default type required? Also, "DelT" makes it sound like it's the type of the deleter rather. Since this struct is the "Impl" Deleter, either name it "ImplT" or "DataT" or something like that. I would recommend "ImplT" ... it can't conflict within its own scope.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141865/new/

https://reviews.llvm.org/D141865