[PATCH] D141565: [RISCV][CodeGen] Account for LMUL from VS2 for Vector Reduction Instructions

Michael Maitland via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 16 11:43:04 PST 2023


michaelmaitland added a comment.
Herald added a subscriber: luke.

The suffixes `From_UpperBound` and `From_MX` come from the naming of the `LMULWriteRes` in the ScheduleV file. I think it makes sense to differentiate these `LMULWriteRes` with some sort of suffix, because they represent behavior that is different than the other `LMULWriteRes` definitions. I think `From` is a good suffix choice. Perhaps a comment above the definition of these `LMULWriteRes`s that elaborates on the meaning of the suffix would be a helpful reference.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141565/new/

https://reviews.llvm.org/D141565



More information about the llvm-commits mailing list