[PATCH] D119049: [LLD] Allow usage of LLD as a library

Zhuoran Yin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 16 09:21:14 PST 2023


jerryyin added a comment.

Thanks for your work @aganea. I abstain from giving review from lld's implementation side but thing looks good on the `ROCm.cpp` unit test. (BTW, do you aim to create that unit test as a demo and then to remove it later? Or else i'd expect to see the "Inputs" folder mocked up in certain way.) Although I did notice a fair amount of test breakages on windows. If you are still actively working on it, I'm willing to approve it once you fix the test failures. Also I plan to give this a test by pulling this diff locally assuming the base of this diff wouldn't cause too much conflicts with our tip of clone.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119049/new/

https://reviews.llvm.org/D119049



More information about the llvm-commits mailing list