[PATCH] D141823: [SCEV] More precise trip multiples

[Joshua Cao via Phabricator via llvm-commits]

caojoshua added a comment.

In D141823#4055951 <https://reviews.llvm.org/D141823#4055951>, @nikic wrote:

> Precommit tests please.

What is precommit test? I've been running llvm-lit llvm/test



================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:6323
+    const SCEVTruncateExpr *T = cast<SCEVTruncateExpr>(S);
+    return getMaxConstantMultiple(T->getOperand()).trunc(BitWidth);
   }
----------------
nikic wrote:
> I don't think this is correct. `trunc(X nuw* C)` is not, in general, the same as `trunc(X) nuw* trunc(C)`.
Thats a good point. Need to think about this. I think we can fall back to count min trailing zeros.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141823/new/

https://reviews.llvm.org/D141823