[PATCH] D141487: [LoopUnroll] Directly update DT instead of DTU.
Jakub Kuderski via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 16 08:10:31 PST 2023
kuhar accepted this revision.
kuhar added a comment.
This revision is now accepted and ready to land.
This looks fine to me but I haven't looked carefully at the surrounding code. Ideally, I think this should albo be reviewed by someone familiar with the loop unrolling implementation.
================
Comment at: llvm/lib/Transforms/Utils/LoopUnroll.cpp:774
+ DTUToUse = nullptr;
+ auto Pair = ExitInfos.begin();
+ ExitInfo &Info = Pair->second;
----------------
nit: we can use structured bindings here: `auto& [Something, ExitInfo] = *ExitInfos.begin();`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141487/new/
https://reviews.llvm.org/D141487
More information about the llvm-commits
mailing list