[PATCH] D140271: [NFCI][llvm-exegesis] Benchmark: parallelize codegen (5x ... 8x less wallclock)

[Clement Courbet via Phabricator via llvm-commits]

courbet added a comment.

In D140271#4056430 <https://reviews.llvm.org/D140271#4056430>, @lebedev.ri wrote:

> In D140271#4056202 <https://reviews.llvm.org/D140271#4056202>, @courbet wrote:
>
>>> Are you seriously saying that 10x wallclock improvement is negligible?
>>
>> 10x speed improvement is not negligible. I'm simply questioning whether speed matters in this case.
>>
>> If the speed improvement came at no cost, that would be a no-brainer. But there is a speed/readability tradeoff, which we need to evaluate.
>
> All the changes here are to a **single** function,
> that isn't really going to change further anyway.
> It's not like this requires changes to many places.

I don't think number of touched functions is an agree-upon measure of complexity :) I would even argue that splitting in more functions might make the code less complex.

But again, my point is more about usefulness to users, and right now it looks like the change leaves both reviewers (that happen to be users) asking about complexity/usefulness ratio. But both these users also might tend to have the same usage of the tool, so maybe we're not seeing the whole picture - maybe ask for more opinions ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140271/new/

https://reviews.llvm.org/D140271