[PATCH] D141829: [AArch64] fold subs ugt/ult to ands when the second operand is a mask

[Sam Tebbs via Phabricator via llvm-commits]

samtebbs accepted this revision.
samtebbs added a comment.
This revision is now accepted and ready to land.

Thanks for this, it's looking great, with one small suggestion.



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:19823
+  assert((CCIndex == 2 && CmpIndex == 3) &&
+         "CCIndex should be 2, CmpIndex should be 3 for now. Update the assert "
+         "if we have new case");
----------------
I'd reword the assertion message to be more like "Expected CCIndex to be 2 and CmpIndex to be 3", to make it more like existing assertions. The part about updating it would be better in a comment, in my opinion.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141829/new/

https://reviews.llvm.org/D141829