[PATCH] D140271: [NFCI][llvm-exegesis] Benchmark: parallelize codegen (5x ... 8x less wallclock)

[Clement Courbet via Phabricator via llvm-commits]

courbet added a comment.

> Are you seriously saying that 10x wallclock improvement is negligible?

10x speed improvement is not negligible. I'm simply questioning whether speed matters in this case.

If the speed improvement came at no cost, that would be a no-brainer. But there is a speed/readability tradeoff, which we need to evaluate.

In my personal experience, I did not feel that benchmarking speed was ever an issue, but I do feel that this code is more complex to understand. Therefore to me that tradeoff is negative. If other people feel otherwise I'm happy to reconsider.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140271/new/

https://reviews.llvm.org/D140271