[PATCH] D141829: [AArch64] fold subs ugt/ult to ands when the second operand is a mask

Mon Jan 16 05:57:28 PST 2023

samtebbs added inline comments.

================
Comment at: llvm/test/CodeGen/AArch64/andcompare.ll:2406
+define i32 @cmp_to_ands1(i32 %num) {
+; SDISEL-LABEL: cmp_to_subs1:
+; SDISEL:       // %bb.0:
----------------
bcl5980 wrote:
> samtebbs wrote:
> > Looks like the labels in the check statements are mixed up.
> I'm sorry but I haven't understand what you said. What labels are mixed up? One of the result is SDAG and the other is GISel.
The IR function is called cmp_to_ands1 but the check statement is looking for cmp_to_subs1, that's why the test is failing: https://reviews.llvm.org/harbormaster/unit/view/5713977/

It's the same for the other IR functions below.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141829/new/

https://reviews.llvm.org/D141829