[PATCH] D141829: [AArch64] fold subs ugt/ult to ands when the second operand is a mask

Sam Tebbs via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 16 03:51:33 PST 2023


samtebbs added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:19898
+  SmallVector<SDValue, 8> Ops;
+  for (unsigned i = 0; i != N->getNumOperands(); ++i) {
+    if (i == CCIndex)
----------------
Do you know if CCIndex and CmpIndex always have consistent values? If so it would be cleaner and faster to not use a loop and instead initialise the Ops vector with the correct values in the correct places.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141829/new/

https://reviews.llvm.org/D141829



More information about the llvm-commits mailing list