[PATCH] D137360: [Linker] Remove nocallback attribute while linking
Gulfem Savrun Yeniceri via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 13 17:10:48 PST 2023
gulfem marked an inline comment as done.
gulfem added inline comments.
================
Comment at: llvm/lib/Linker/IRMover.cpp:1558
+ for (Instruction &I : BB)
+ if (CallInst *CI = dyn_cast<CallInst>(&I))
+ CI->removeFnAttr(Attribute::NoCallback);
----------------
tejohnson wrote:
> Should this be CallBase (so it handles InvokeInst as well)? I missed during the review, but it was pointed out by @arsenm here: https://reviews.llvm.org/D139209#inline-1368889
Thanks for pointing that out, and and I uploaded D141740.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137360/new/
https://reviews.llvm.org/D137360
More information about the llvm-commits
mailing list