[PATCH] D137360: [Linker] Remove nocallback attribute while linking

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 13 16:16:06 PST 2023


tejohnson added a subscriber: arsenm.
tejohnson added inline comments.


================
Comment at: llvm/lib/Linker/IRMover.cpp:1558
+      for (Instruction &I : BB)
+        if (CallInst *CI = dyn_cast<CallInst>(&I))
+          CI->removeFnAttr(Attribute::NoCallback);
----------------
Should this be CallBase (so it handles InvokeInst as well)? I missed during the review, but it was pointed out by @arsenm here: https://reviews.llvm.org/D139209#inline-1368889


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137360/new/

https://reviews.llvm.org/D137360



More information about the llvm-commits mailing list