[PATCH] D141720: [mlgo] Remove the protobuf dependency

[Aiden Grossman via Phabricator via llvm-commits]

aidengrossman added a comment.

LGTM
One really minor nit.

I'm assuming the performance difference is pretty minimal between this and the TF Protobuf implementation within the overall training process (although most of the overhead would probably by in parsing on the Python side I would think)?



================
Comment at: llvm/test/CodeGen/MLRegalloc/dev-mode-extra-features-logging.ll:25
 ; CHECK-NOT: nan
-; CHECK-LABEL: key: \"instructions\"
 ; Check the first five opcodes in the first eviction problem
+; Also, the first eviction problem is significantly less than 300 instructions. Check
----------------
Maybe note here explicitly we're regexing most of the opcodes due to exact values causing test failures over minor differences? Otherwise the regex might be somewhat hard to parse without additional context.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141720/new/

https://reviews.llvm.org/D141720