[PATCH] D141720: [mlgo] Remove the protobuf dependency

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 13 12:29:24 PST 2023


mtrofin created this revision.
mtrofin added a reviewer: kazu.
Herald added subscribers: hiraditya, qcolombet, MatzeB.
Herald added a project: All.
mtrofin requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

The dependency was due to the log format. This change switches to the
previously-introduced (D139370 <https://reviews.llvm.org/D139370>) "dependency-free" logger instead of the
protobuf-based one.

A subsequent change will clean out the unnecessary abstraction left
behind.

This change drops the logger unittest, we have sufficient test coverage
via lit tests, and a unit test would require adding, unnecesarily, a log
reader (the reader is expected to be python, for the ML side, and there
is a reader for that under Analysis/models, used for tests).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D141720

Files:
  llvm/CMakeLists.txt
  llvm/cmake/modules/TensorFlowCompile.cmake
  llvm/include/llvm/Analysis/Utils/TrainingLogger.h
  llvm/lib/Analysis/CMakeLists.txt
  llvm/lib/Analysis/DevelopmentModeInlineAdvisor.cpp
  llvm/lib/Analysis/TrainingLogger.cpp
  llvm/test/CodeGen/MLRegalloc/Inputs/reference-log-noml.txt
  llvm/test/CodeGen/MLRegalloc/Inputs/reference-prio-log-noml.txt
  llvm/test/CodeGen/MLRegalloc/dev-mode-extra-features-logging.ll
  llvm/test/CodeGen/MLRegalloc/dev-mode-log-2-fcts.ll
  llvm/test/CodeGen/MLRegalloc/dev-mode-logging.ll
  llvm/test/CodeGen/MLRegalloc/dev-mode-prio-logging.ll
  llvm/test/Transforms/Inline/ML/bounds-checks-rewards.ll
  llvm/test/Transforms/Inline/ML/dev-mode-log-deleted.ll
  llvm/test/Transforms/Inline/ML/development-training-log.ll
  llvm/test/Transforms/Inline/ML/ml-test-development-mode.ll
  llvm/unittests/Analysis/CMakeLists.txt
  llvm/unittests/Analysis/TrainingLoggerTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D141720.489097.patch
Type: text/x-patch
Size: 260418 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230113/4f4a1d53/attachment-0001.bin>


More information about the llvm-commits mailing list