[PATCH] D112466: [NVPTX] Drop memory references of LDG/LDU

[Andrew Savonichev via Phabricator via llvm-commits]

asavonic added inline comments.


================
Comment at: llvm/lib/Target/NVPTX/NVPTXISelDAGToDAG.cpp:1674-1675
 
-  MachineMemOperand *MemRef = Mem->getMemOperand();
-  CurDAG->setNodeMemRefs(cast<MachineSDNode>(LD), {MemRef});
-
----------------
tra wrote:
> The function also handles regular loads/stores (e.g. `NVPTXISD::LoadV4`) and those should still mark the node as a memory reference.
Can you elaborate why we need to treat these nodes separately? A regular load can be lowered to LDG if it matches `canLowerToLDG`, but the final instruction is still LDG (aka `ld.global.nc`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112466/new/

https://reviews.llvm.org/D112466