[PATCH] D112466: [NVPTX] Drop memory references of LDG/LDU
Artem Belevich via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 11 12:26:07 PST 2023
tra added a comment.
LGTM in principle.
================
Comment at: llvm/lib/Target/NVPTX/NVPTXISelDAGToDAG.cpp:1674-1675
- MachineMemOperand *MemRef = Mem->getMemOperand();
- CurDAG->setNodeMemRefs(cast<MachineSDNode>(LD), {MemRef});
-
----------------
The function also handles regular loads/stores (e.g. `NVPTXISD::LoadV4`) and those should still mark the node as a memory reference.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112466/new/
https://reviews.llvm.org/D112466
More information about the llvm-commits
mailing list