[PATCH] D141444: [GCOV] Set !kcfi_type metadata for indirectly called functions

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 11 11:16:42 PST 2023


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/test/Transforms/GCOVProfiling/kcfi.ll:1
+; RUN: mkdir -p %t && cd %t
+; RUN: opt < %s -S -passes=insert-gcov-profiling | FileCheck %s
----------------



================
Comment at: llvm/test/Transforms/GCOVProfiling/kcfi.ll:4
+
+;; Ensure __llvm_gcov_(writeout|reset|init) have !kcfi_type with KCFI.
+
----------------
Line one would be better. (I know that many tests place the comment after all RUN lines.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141444/new/

https://reviews.llvm.org/D141444



More information about the llvm-commits mailing list