[PATCH] D141444: [GCOV] Set !kcfi_type metadata for indirectly called functions

Sami Tolvanen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 11 10:53:50 PST 2023


samitolvanen added a comment.

In D141444#4042006 <https://reviews.llvm.org/D141444#4042006>, @MaskRay wrote:

> Ensuring that every instrumentation works with kcfi is a lot of work on the compiler side (think that another instrumentation technique comes up, we need to update O(n) existing instrumentation passes) and I don't quite agree that it's compiler's responsibility.
> But if sanitizers and gcov are all, I think it's fine...

I agree, and yes, ASAN and GCOV are the only uses of global constructors in Linux.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141444/new/

https://reviews.llvm.org/D141444



More information about the llvm-commits mailing list