[PATCH] D138953: llvm-reduce: Try to kill parallel workitems once we have a result.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: llvm/tools/llvm-reduce/TestRunner.cpp:79
+    WaitPI = sys::Wait(PI, SecondsToWait, &ErrMsg, nullptr, Polling);
+    if (WaitPI.Pid == 0) {
+      // Process has not changed state.
----------------
fhahn wrote:
> nit: might be good to use early exit to reduce indent?
Switched to while loop to reduce indent


================
Comment at: llvm/tools/llvm-reduce/TestRunner.cpp:84-86
+        // The current Program API does not have a way to directly kill, so
+        // we're stuck using a 1 second timeout.
+        SecondsToWait = 1;
----------------
I also fixed this problem, so I've switched this to a 0 second timeout. sys::Wait now uses optional, and distinguishes nullopt=wait infinity and 0 is expect immediate exit


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138953/new/

https://reviews.llvm.org/D138953