[PATCH] D138953: llvm-reduce: Try to kill parallel workitems once we have a result.

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks! Might be good to wait with landing until tomorrow in case @aeubanks or anybody else has additional comments.



================
Comment at: llvm/tools/llvm-reduce/ReducerWorkItem.h:19
 
+#include <atomic>
+
----------------
is this include need here? Seems like nothing from `<atomic>` is used here.


================
Comment at: llvm/tools/llvm-reduce/TestRunner.cpp:79
+    WaitPI = sys::Wait(PI, SecondsToWait, &ErrMsg, nullptr, Polling);
+    if (WaitPI.Pid == 0) {
+      // Process has not changed state.
----------------
nit: might be good to use early exit to reduce indent?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138953/new/

https://reviews.llvm.org/D138953