[PATCH] D141408: [CodeGen] Introduce a generic MEMBARRIER instruction [mostly-nfc]

Sam Elliott via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 10 15:18:09 PST 2023


lenary added a comment.

Broadly, this looks right. I'm glad stuff is finally moving on changes in this direction.

Why does this barrier not need an ordering, but ARM/AArch64 do? Some of the targets in this patch still have weak memory orderings (RISC-V). Is the plan to update the MEMBARRIER with the ordering later, in a way that won't actually affect the selection for these targets so far?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141408/new/

https://reviews.llvm.org/D141408



More information about the llvm-commits mailing list