[PATCH] D140457: [BOLT] Process fragment siblings in lite mode, keep lite mode on

Maksim Panchenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 10 12:00:18 PST 2023


maksfb added a comment.

In D140457#4038808 <https://reviews.llvm.org/D140457#4038808>, @Amir wrote:

> In D140457#4038384 <https://reviews.llvm.org/D140457#4038384>, @maksfb wrote:
>
>> What do you think about preliminary matching fragments while reading the symbol table for non-stripped binaries? It's almost exactly what you are doing in this diff, right?
>
> Let me look into that. I thought that `selectFunctionsToProcess` is the appropriate place since at that point we know which functions we want to skip and it's the earliest place to override that.

Sorry, I wasn't clear. I mean to match fragments early and then use the fragment dependency info in `selectFunctionsToProcess()`. It's still the right place to set functions as ignored.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140457/new/

https://reviews.llvm.org/D140457



More information about the llvm-commits mailing list