[PATCH] D140457: [BOLT] Process fragment siblings in lite mode, keep lite mode on

Mon Jan 9 23:39:34 PST 2023

Amir marked an inline comment as done.
Amir added a comment.

In D140457#4038384 <https://reviews.llvm.org/D140457#4038384>, @maksfb wrote:

> What do you think about preliminary matching fragments while reading the symbol table for non-stripped binaries? It's almost exactly what you are doing in this diff, right?

Let me look into that. I thought that `selectFunctionsToProcess` is the appropriate place since at that point we know which functions we want to skip and it's the earliest place to override that.

================
Comment at: bolt/test/X86/fragment-lite-reverse.s:47
+
+  .globl foo.cold.1
+  .type foo.cold.1, %function
----------------
maksfb wrote:
> How is `foo` different from `main` for the purpose of this test?
> 
> From what I've seen, cold fragments typically have local visibility (but we shouldn't rely on it), while main fragments could be of any type.
Fixed.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140457/new/

https://reviews.llvm.org/D140457