[PATCH] D141411: [AArch64] Make -march and target("arch=..") attributes imply dependent features

[Daniel Kiss via Phabricator via llvm-commits]

danielkiss accepted this revision.
danielkiss added a comment.
This revision is now accepted and ready to land.

jut a NIT, LGTM otherwise.



================
Comment at: clang/lib/Basic/Targets/AArch64.cpp:743
   llvm::AArch64::ArchKind AK = llvm::AArch64::getSubArchArchKind(Name);
-  // Add all previous architecture versions.
-  // In case of v9.x the v8.x counterparts are added too.
-  if ("9" == getArchVersionString(AK))
-    for (llvm::AArch64::ArchKind I = llvm::AArch64::convertV9toV8(AK);
-         I != llvm::AArch64::ArchKind::INVALID; --I)
+  if (AK != llvm::AArch64::ArchKind::INVALID) {
+    // In case of v9.x the v8.x counterparts are added too.
----------------
what do you think?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141411/new/

https://reviews.llvm.org/D141411