[PATCH] D141411: [AArch64] Make -march and target("arch=..") attributes imply dependent features

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 10 10:37:27 PST 2023


dmgreen created this revision.
dmgreen added reviewers: ilinpv, danielkiss, DavidSpickett, ostannard, efriedma.
Herald added subscribers: ctetreau, kristof.beyls.
Herald added a project: All.
dmgreen requested review of this revision.
Herald added a project: LLVM.

Specifying an architecture revision should also add feature strings for any dependent default extensions. Otherwise the new checks for target-dependent features for acle intrinsics from D134353 <https://reviews.llvm.org/D134353> and D132034 <https://reviews.llvm.org/D132034> can fail.

This patch does that in setFeatureEnabled, similar to the addition of dependent architecture revisions. `+sve` also needs to be added to armv9 architectures in the target parser, as it is implied by `+sve2`.

Fixes #59911


https://reviews.llvm.org/D141411

Files:
  clang/lib/Basic/Targets/AArch64.cpp
  clang/test/CodeGen/aarch64-targetattr-arch.c
  clang/test/CodeGen/aarch64-targetattr.c
  llvm/include/llvm/TargetParser/AArch64TargetParser.def

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D141411.487874.patch
Type: text/x-patch
Size: 8834 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230110/0c093029/attachment.bin>


More information about the llvm-commits mailing list