[PATCH] D141311: [RISCV] Avoid emitting hardware fences for singlethread fences

Mon Jan 9 12:31:16 PST 2023

reames planned changes to this revision.
reames added a comment.

In D141311#4037335 <https://reviews.llvm.org/D141311#4037335>, @jrtc27 wrote:

> In D141311#4037302 <https://reviews.llvm.org/D141311#4037302>, @reames wrote:
>
>> In D141311#4037290 <https://reviews.llvm.org/D141311#4037290>, @jrtc27 wrote:
>>
>>> If every backend is doing it shouldn't this be a generic thing rather than copy/pasted to every backend?
>>
>> Agreed.  I looked briefly at doing this.  I think we could probably share the SDAG pieces; the pseudos look less obvious.  Happy to take a pass at this, but I'd prefer that be non-blocking for this change.  You okay with that?
>
> Yeah, I just wish it were done that way from the start :( busywork as a result

The SDAG part turned out to be easier than I'd realized, and is now posted: https://reviews.llvm.org/D141317

I'm going to rebase this patch once that one lands.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141311/new/

https://reviews.llvm.org/D141311