[PATCH] D141153: [LocalStackSlotAllocation] Minor simplifications. NFC

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/LocalStackSlotAllocation.cpp:388
     // register.
-    if (UsedBaseReg &&
+    if (BaseReg.isValid() &&
         lookupCandidateBaseReg(BaseReg, BaseOffset, FrameSizeAdjust,
----------------
craig.topper wrote:
> arsenm wrote:
> > Conversion to bool also works, you don't need an explicit isValid
> I think it’s going through operator unsigned which I thought we wanted to remove from Register someday.
Yes, but at that point it could have operator bool


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141153/new/

https://reviews.llvm.org/D141153