[PATCH] D141153: [LocalStackSlotAllocation] Minor simplifications. NFC

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 9 08:48:38 PST 2023


craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/LocalStackSlotAllocation.cpp:388
     // register.
-    if (UsedBaseReg &&
+    if (BaseReg.isValid() &&
         lookupCandidateBaseReg(BaseReg, BaseOffset, FrameSizeAdjust,
----------------
arsenm wrote:
> Conversion to bool also works, you don't need an explicit isValid
I think it’s going through operator unsigned which I thought we wanted to remove from Register someday.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141153/new/

https://reviews.llvm.org/D141153



More information about the llvm-commits mailing list