[PATCH] D140581: [NVPTX] Enforce minumum alignment of 4 for byval parametrs in a function prototype

[Pavel Kopyl via Phabricator via llvm-commits]

pavelkopyl added inline comments.


================
Comment at: llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp:1615-1623
+      Align OptimalAlign;
+      if (isKernelFunc)
+        OptimalAlign = getOptimalAlignForParam(ETy);
+      else {
+        // ByVal parameters of device functions require special alignment.
+        MaybeAlign ParamAlign = PAL.getParamAlignment(paramIndex);
+        OptimalAlign = TLI->getFunctionByValParamAlign(
----------------
tra wrote:
> Nit. This all could be folded into 
> 
> ```
> Align OptimalAlign = isKernelFunc 
>         ? getOptimalAlignForParam(ETy);
>         : TLI->getFunctionByValParamAlign(F, ETy, PAL.getParamAlignment(paramIndex).valueOrOne(), DL);
> ```
Thank you. Done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140581/new/

https://reviews.llvm.org/D140581