[PATCH] D139872: [llvm][CallBrPrepare] split critical edges

[Bill Wendling via Phabricator via llvm-commits]

void accepted this revision.
void added a comment.
This revision is now accepted and ready to land.

In D139872#4014003 <https://reviews.llvm.org/D139872#4014003>, @nickdesaulniers wrote:

> - remove unnecessary if, as per @aeubanks and @void

I've been thinking about this and I'm not really sure why LLVM hasn't created their own version of `assert` yet. It could be something as simple as this:

  #define LLVM_ASSERT(cond, msg)  if (!cond) assert(false && msg)

But that's a separate issue.

This pass looks okay to me. I'll accept, but I think others who commented should also accept.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139872/new/

https://reviews.llvm.org/D139872