[PATCH] D139767: [DFAPacketizer] Move DefaultVLIWScheduler class declaration to header file

Darshan Bhat via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 6 21:55:59 PST 2023


DarshanRamakant added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/DFAPacketizer.h:143
   // The VLIW Scheduler.
   DefaultVLIWScheduler *VLIWScheduler;
   // Vector of instructions assigned to the current packet.
----------------
@kparzysz , this type will become incomplete class type for the child class of VLIWPacketizerList unless declaration of "DefaultVLIWScheduler" is moved to this header. 
Since this member is a protected member, I assume the design intention was to make it available to child class.

My usecase was to access this member and call "schedule()" method of it. 

This patch just moves the declaration from cpp file to header file. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139767/new/

https://reviews.llvm.org/D139767



More information about the llvm-commits mailing list