[PATCH] D141180: [X86] Only match BMI (BLSR, BLSI, BLSMSK) if the add/sub op is single use

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

In D141180#4032986 <https://reviews.llvm.org/D141180#4032986>, @goldstein.w.n wrote:

> NOTE/Request for advise: This regresses the tests in `GlobalISel`. I think its because of the single-use `defs` in the td, as even if I made them just return `true` the tests the BMI ops still werent getting matched. BMI is still does work (see the `bmi-out-of-order.ll` tests and `bmi.ll` is still fine).
>
> Can anyone give me some guidance about how to get the patterns to use custom `defs` and work for `GlobalISel`?

I wouldn't worry about GlobalISel. It's not actively being used or developed as far as I know.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141180/new/

https://reviews.llvm.org/D141180