[PATCH] D141180: [X86] Only match BMI (BLSR, BLSI, BLSMSK) if the add/sub op is single use

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 6 19:45:29 PST 2023


goldstein.w.n added a comment.

NOTE/Request for advise: This regresses the tests in `GlobalISel`. I think its because of the single-use `defs` in the td, as even if I made them just return `true` the tests the BMI ops still werent getting matched. BMI is still does work (see the `bmi-out-of-order.ll` tests and `bmi.ll` is still fine).

Can anyone give me some guidance about how to get the patterns to use custom `defs` and work for `GlobalISel`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141180/new/

https://reviews.llvm.org/D141180



More information about the llvm-commits mailing list