[PATCH] D141127: AMDGPU/GlobalISel: Widen s1 SGPR constants during regbankselect

[Matt Arsenault via Phabricator via llvm-commits]

arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/br-constant-invalid-sgpr-copy.ll:5
+
+; This was mishandling the constant true and false values used as a
+; scalar branch condition.
----------------
Pierre-vh wrote:
> It would have been nice to have the test pre-committed to see exactly what has been fixed, but it's a small test/diff so I'm not going to ask to split it
> Can you paste the pre-change ISA in a comment so I can see the before/after?
It failed to compile before (for wave64, it happens to work on wave32). The selector is too permissive, which I'm planning on fixing separately 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141127/new/

https://reviews.llvm.org/D141127