[PATCH] D139902: IR: Add nofpclass parameter attribute
Jakub Kuderski via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 6 08:37:58 PST 2023
kuhar added a comment.
Overall I like this direction i.e., putting a set of classes in a single attribute, which seems scalable with the number of classes and reminds me of memory effects attributes (`memory(...)`)
================
Comment at: llvm/unittests/IR/VerifierTest.cpp:135-136
+ if (InvalidMask == 0) {
+ EXPECT_TRUE(ErrMsg.startswith(
+ "Attribute 'nofpclass' must have at least one test bit set"))
+ << ErrMsg;
----------------
nit: I think `EXPECT_THAT(Error, StartsWith("..."))` would be more idiomatic and concise. But if you prefer to follow the style used by the pre-existing checks in this file that's also fine to me.
also below
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139902/new/
https://reviews.llvm.org/D139902
More information about the llvm-commits
mailing list