[PATCH] D139902: IR: Add nofpclass parameter attribute

[Jakub Kuderski via Phabricator via llvm-commits]

kuhar added a comment.

Overall I like this direction i.e., putting a set of classes in a single attribute, which seems scalable with the number of classes and reminds me of memory effects attributes (`memory(...)`)



================
Comment at: llvm/unittests/IR/VerifierTest.cpp:135-136
+    if (InvalidMask == 0) {
+      EXPECT_TRUE(ErrMsg.startswith(
+          "Attribute 'nofpclass' must have at least one test bit set"))
+          << ErrMsg;
----------------
nit: I think `EXPECT_THAT(Error, StartsWith("..."))` would be more idiomatic and concise. But if you prefer to follow the style used by the pre-existing checks in this file that's also fine to me.

also below


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139902/new/

https://reviews.llvm.org/D139902