[PATCH] D141135: [RFC][GlobalISel] Replace the current GlobalISel matcher with a bottom-up matcher

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 6 07:00:18 PST 2023


arsenm added a comment.

> Compiling LLVM is slightly longer with this change applied: 25m35.471s vs 28m51.797

This is huge. I don't understand this part. Surely you don't have bootstrapped globalisel working? Why this slowdown?

> However, lot of test case would need to be changed because they do not expect those dead instructions. A simple solution would be to make a second loop over the instructions, just removing the trivially dead instructions, which would be faster than doing a full iteration.

We can also just update tests. Avoiding test changes isn't a good reason to do something


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141135/new/

https://reviews.llvm.org/D141135



More information about the llvm-commits mailing list