[PATCH] D141128: AMDGPU/GlobalISel: Make regbankselect of implicit_def consistent with constants

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/regbankselect-implicit-def.mir:135-137
+    ; CHECK-NEXT: [[DEF:%[0-9]+]]:sgpr(s32) = G_IMPLICIT_DEF
+    ; CHECK-NEXT: [[TRUNC:%[0-9]+]]:sgpr(s1) = G_TRUNC [[DEF]](s32)
+    ; CHECK-NEXT: [[ZEXT:%[0-9]+]]:sgpr(s32) = G_ZEXT [[TRUNC]](s1)
----------------
foad wrote:
> Patch looks reasonable but I don't understand why it has this effect.
Previously the widen to s32 was applied to the select input, now it's being applied to the implicit_def's output too, so you get both. We currently don't try to fold out intermediate states


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141128/new/

https://reviews.llvm.org/D141128