[llvm] 4abc820 - [CallSiteSplitting] Convert test to opaque pointers (NFC)

[Nikita Popov via llvm-commits]

Author: Nikita Popov
Date: 2023-01-06T14:35:31+01:00
New Revision: 4abc820c667179e2bd72cb410185e7036b1d1cf4

URL: https://github.com/llvm/llvm-project/commit/4abc820c667179e2bd72cb410185e7036b1d1cf4
DIFF: https://github.com/llvm/llvm-project/commit/4abc820c667179e2bd72cb410185e7036b1d1cf4.diff

LOG: [CallSiteSplitting] Convert test to opaque pointers (NFC)

Keeping the bitcasts here because this is in part testing the
(legal) bitcast after a musttail call, even though it's no longer
really relevant.

Added: 
    

Modified: 
    llvm/test/Transforms/CallSiteSplitting/musttail.ll

Removed: 
    


################################################################################
diff  --git a/llvm/test/Transforms/CallSiteSplitting/musttail.ll b/llvm/test/Transforms/CallSiteSplitting/musttail.ll
index e55e3f52333be..0f989a2ae4ad1 100644
--- a/llvm/test/Transforms/CallSiteSplitting/musttail.ll
+++ b/llvm/test/Transforms/CallSiteSplitting/musttail.ll
@@ -2,75 +2,75 @@
 
 ;CHECK-LABEL: @caller
 ;CHECK-LABEL: Top.split:
-;CHECK: %ca1 = musttail call i8* @callee(i8* null, i8* %b)
-;CHECK: %cb2 = bitcast i8* %ca1 to i8*
-;CHECK: ret i8* %cb2
+;CHECK: %ca1 = musttail call ptr @callee(ptr null, ptr %b)
+;CHECK: %cb2 = bitcast ptr %ca1 to ptr
+;CHECK: ret ptr %cb2
 ;CHECK-LABEL: TBB.split
-;CHECK: %ca3 = musttail call i8* @callee(i8* nonnull %a, i8* null)
-;CHECK: %cb4 = bitcast i8* %ca3 to i8*
-;CHECK: ret i8* %cb4
-define i8* @caller(i8* %a, i8* %b) {
+;CHECK: %ca3 = musttail call ptr @callee(ptr nonnull %a, ptr null)
+;CHECK: %cb4 = bitcast ptr %ca3 to ptr
+;CHECK: ret ptr %cb4
+define ptr @caller(ptr %a, ptr %b) {
 Top:
-  %c = icmp eq i8* %a, null
+  %c = icmp eq ptr %a, null
   br i1 %c, label %Tail, label %TBB
 TBB:
-  %c2 = icmp eq i8* %b, null
+  %c2 = icmp eq ptr %b, null
   br i1 %c2, label %Tail, label %End
 Tail:
-  %ca = musttail call i8* @callee(i8* %a, i8* %b)
-  %cb = bitcast i8* %ca to i8*
-  ret i8* %cb
+  %ca = musttail call ptr @callee(ptr %a, ptr %b)
+  %cb = bitcast ptr %ca to ptr
+  ret ptr %cb
 End:
-  ret i8* null
+  ret ptr null
 }
 
-define i8* @callee(i8* %a, i8* %b) noinline {
-  ret i8* %a
+define ptr @callee(ptr %a, ptr %b) noinline {
+  ret ptr %a
 }
 
 ;CHECK-LABEL: @no_cast_caller
 ;CHECK-LABEL: Top.split:
-;CHECK: %ca1 = musttail call i8* @callee(i8* null, i8* %b)
-;CHECK: ret i8* %ca1
+;CHECK: %ca1 = musttail call ptr @callee(ptr null, ptr %b)
+;CHECK: ret ptr %ca1
 ;CHECK-LABEL: TBB.split
-;CHECK: %ca2 = musttail call i8* @callee(i8* nonnull %a, i8* null)
-;CHECK: ret i8* %ca2
-define i8* @no_cast_caller(i8* %a, i8* %b) {
+;CHECK: %ca2 = musttail call ptr @callee(ptr nonnull %a, ptr null)
+;CHECK: ret ptr %ca2
+define ptr @no_cast_caller(ptr %a, ptr %b) {
 Top:
-  %c = icmp eq i8* %a, null
+  %c = icmp eq ptr %a, null
   br i1 %c, label %Tail, label %TBB
 TBB:
-  %c2 = icmp eq i8* %b, null
+  %c2 = icmp eq ptr %b, null
   br i1 %c2, label %Tail, label %End
 Tail:
-  %ca = musttail call i8* @callee(i8* %a, i8* %b)
-  ret i8* %ca
+  %ca = musttail call ptr @callee(ptr %a, ptr %b)
+  ret ptr %ca
 End:
-  ret i8* null
+  ret ptr null
 }
 
 ;CHECK-LABEL: @void_caller
 ;CHECK-LABEL: Top.split:
-;CHECK: musttail call void @void_callee(i8* null, i8* %b)
+;CHECK: musttail call void @void_callee(ptr null, ptr %b)
 ;CHECK: ret void
 ;CHECK-LABEL: TBB.split
-;CHECK: musttail call void @void_callee(i8* nonnull %a, i8* null)
+;CHECK: musttail call void @void_callee(ptr nonnull %a, ptr null)
 ;CHECK: ret void
-define void @void_caller(i8* %a, i8* %b) {
+define void @void_caller(ptr %a, ptr %b) {
 Top:
-  %c = icmp eq i8* %a, null
+  %c = icmp eq ptr %a, null
   br i1 %c, label %Tail, label %TBB
 TBB:
-  %c2 = icmp eq i8* %b, null
+  %c2 = icmp eq ptr %b, null
   br i1 %c2, label %Tail, label %End
 Tail:
-  musttail call void @void_callee(i8* %a, i8* %b)
+  musttail call void @void_callee(ptr %a, ptr %b)
   ret void
 End:
   ret void
 }
 
-define void @void_callee(i8* %a, i8* %b) noinline {
+define void @void_callee(ptr %a, ptr %b) noinline {
   ret void
 }
 
@@ -78,27 +78,27 @@ define void @void_callee(i8* %a, i8* %b) noinline {
 ;   machinery a bit more.
 ;CHECK-LABEL: @larger_cfg_caller
 ;CHECK-LABEL: Top.split:
-;CHECK: %r1 = musttail call i8* @callee(i8* null, i8* %b)
-;CHECK: ret i8* %r1
+;CHECK: %r1 = musttail call ptr @callee(ptr null, ptr %b)
+;CHECK: ret ptr %r1
 ;CHECK-LABEL: TBB.split
-;CHECK: %r2 = musttail call i8* @callee(i8* nonnull %a, i8* null)
-;CHECK: ret i8* %r2
-define i8* @larger_cfg_caller(i8* %a, i8* %b) {
+;CHECK: %r2 = musttail call ptr @callee(ptr nonnull %a, ptr null)
+;CHECK: ret ptr %r2
+define ptr @larger_cfg_caller(ptr %a, ptr %b) {
 Top:
-  %cond1 = icmp eq i8* %a, null
+  %cond1 = icmp eq ptr %a, null
   br i1 %cond1, label %Tail, label %ExtraTest
 ExtraTest:
-  %a0 = load i8, i8* %a
+  %a0 = load i8, ptr %a
   %cond2 = icmp eq i8 %a0, 0
   br i1 %cond2, label %TBB_pred, label %End
 TBB_pred:
   br label %TBB
 TBB:
-  %cond3 = icmp eq i8* %b, null
+  %cond3 = icmp eq ptr %b, null
   br i1 %cond3, label %Tail, label %End
 Tail:
-  %r = musttail call i8* @callee(i8* %a, i8* %b)
-  ret i8* %r
+  %r = musttail call ptr @callee(ptr %a, ptr %b)
+  ret ptr %r
 End:
-  ret i8* null
+  ret ptr null
 }