[PATCH] D141064: [AArch64] Comprehensive tests for atomic operations

Fri Jan 6 03:41:02 PST 2023

lenary accepted this revision.
lenary added a comment.
This revision is now accepted and ready to land.

I am very pro this change - we have had these tests downstream for a few months, and they've helped us catch changes in codegen we might not otherwise have noticed.

As we're about to work on codegen changes for `lse128` and `rcpc3` (part of the 2022 extensions), I think we have enough different configurations to warrant these comprehensive tests. There are, of course, more configurations we could add in the future, and the `generate-tests.py` script should allow us to do so easily.

I am happy that these are split up enough to not cause very slow tests.

I commented on one Nit, below, but I think you can fix it when you commit these.

================
Comment at: llvm/test/CodeGen/AArch64/Atomics/generate-tests.py:244
+            for feat in Feature:
+                header(f, triple, feat, filter_args)
+            all_fence(f)
----------------
Nit: This writes the header into the fence test files multiple times, leaving `The base test file was generated by ./llvm/test/CodeGen/AArch64/Atomics/generate-tests.py` printed multiple times.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141064/new/

https://reviews.llvm.org/D141064