[PATCH] D141119: [AArch64] Fold And/Or into CSel if possible

Sam Tebbs via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 6 03:23:47 PST 2023


samtebbs accepted this revision.
samtebbs added a comment.
This revision is now accepted and ready to land.

LGTM with one suggestion.



================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:555
 
+// topbitsallzero - Return true if only the lower bit is known non-zero
+def topbitsallzero32: PatLeaf<(i32 GPR32:$src), [{
----------------
If I understand these PatLeafs right then they return true if the top bits are zero with the bottom bit being unknown. If so then I think the "known non-zero" part of the comment could be reworded.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141119/new/

https://reviews.llvm.org/D141119



More information about the llvm-commits mailing list