[PATCH] D133927: [DebugInfo] Add support for variadic DBG_INSTR_REFs in LiveDebugValues

Jeremy Morse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 6 02:25:34 PST 2023


jmorse added a comment.

In D133927#4023568 <https://reviews.llvm.org/D133927#4023568>, @StephenTozer wrote:

> Yes - after all the input debug value instructions are converted to the internal representation (`DbgValue`) in the instruction referencing live debug values, variadic `DBG_INSTR_REF`s follow the same code paths as `DBG_VALUE_LIST`s, which had test coverage added when they were introduced. Notably those patches added unit tests, and this patch has nothing to add on top of them. If you think test coverage could be expanded though then I should be able to generate some more cases, it might not be a bad idea to cast a wide net in case there are any rare or insidious errors.

SGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133927/new/

https://reviews.llvm.org/D133927



More information about the llvm-commits mailing list