[PATCH] D133927: [DebugInfo] Add support for variadic DBG_INSTR_REFs in LiveDebugValues
Stephen Tozer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 3 09:35:11 PST 2023
StephenTozer added a comment.
In D133927#4007888 <https://reviews.llvm.org/D133927#4007888>, @jmorse wrote:
> Looks good, but with what feels like low test coverage: remind me, the plumbing required to track variadic locations in LiveDebugValues already landed, and we have tests to cover those new code paths, yes?
Yes - after all the input debug value instructions are converted to the internal representation (`DbgValue`) in the instruction referencing live debug values, variadic `DBG_INSTR_REF`s follow the same code paths as `DBG_VALUE_LIST`s, which had test coverage added when they were introduced. Notably those patches added unit tests, and this patch has nothing to add on top of them. If you think test coverage could be expanded though then I should be able to generate some more cases, it might not be a bad idea to cast a wide net in case there are any rare or insidious errors.
================
Comment at: llvm/test/DebugInfo/MIR/InstrRef/variadic-instr-ref.mir:50
+#
+## TODO: The debug value range should be terminated when the value in $ebx is clobbered.
+#
----------------
jmorse wrote:
> Sounds like a DbgEntityHistoryCalculator matter rather than one for LiveDebugValues, right?
Indeed - there is //some// clobbering that's handled in LiveDebugValues, and I thought this should be one such case, but after checking over it again it's firmly out of LiveDebugValues' wheelhouse.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133927/new/
https://reviews.llvm.org/D133927
More information about the llvm-commits
mailing list