[PATCH] D141060: [opt] Infer DataLayout from triple if not specified

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 6 01:26:52 PST 2023


nikic added a comment.

Sounds reasonable to me. In fact, I kind of thought that this is how it already works...



================
Comment at: llvm/test/Transforms/InstCombine/fls-i16.ll:1
-; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --force-update
 ;
----------------
--force-update here and in a few more places.


================
Comment at: llvm/test/Transforms/InstSimplify/ConstProp/calls-math-finite.ll:3
 ; RUN: opt < %s -passes=instsimplify -S | FileCheck %s
-; RUN: opt < %s -passes=instsimplify -S -mtriple=unknown-unknown-linux-musl | FileCheck -check-prefix=MUSL %s
+; RUN: opt < %s -passes=instsimplify -S -mtriple=x86_64-unknown-linux-musl | FileCheck -check-prefix=MUSL %s
 
----------------
Please precommit a regeneration of this test -- not really clear what actually changed here (if anything).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141060/new/

https://reviews.llvm.org/D141060



More information about the llvm-commits mailing list