[PATCH] D139601: [LoopVectorize] Clear cache of `LoopAccessInfoManager`

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 5 14:58:22 PST 2023


fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, with the comments addressed.



================
Comment at: llvm/test/Transforms/LoopVectorize/X86/pr59319.ll:1
+; RUN: opt -passes=loop-distribute,loop-vectorize -enable-loop-distribute -S \
+; RUN: %s | FileCheck %s
----------------
Saldivarcher wrote:
> Ok, moved to the x86 directory, thanks for pointing that out. 
is it possible to specify a fixed VF/UF using `-force-vector-width=X -force-vector-interleave=Y`?


================
Comment at: llvm/test/Transforms/LoopVectorize/X86/pr59319.ll:5
+target triple = "x86_64-unknown-linux-gnu"
+; REQUIRES: x86-registered-target
+
----------------
not needed now


================
Comment at: llvm/test/Transforms/LoopVectorize/X86/pr59319.ll:8
+define void @reduced(i32* %0, i32* %1, i64 %iv, i32* %2, i64 %iv76, i64 %iv93) {
+; CHECK-LABEL: @reduced(
+entry:
----------------
It still would be good to make sure the IR we generate makes sense. You can use `llvm/utils/update_test_checks.py` to generate checks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139601/new/

https://reviews.llvm.org/D139601



More information about the llvm-commits mailing list