[PATCH] D139601: [LoopVectorize] Clear cache of `LoopAccessInfoManager`

Miguel Saldivar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 4 08:55:22 PST 2023


Saldivarcher added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:10603
+  // Assure that the `LoopAccessManagerInfo` cache is invalidated.
+  LAIs->clear();
+
----------------
fhahn wrote:
> Saldivarcher wrote:
> > @fhahn I wasn't sure where the best place to invalidate cache, if you think I should do it elsewhere I can do that. 
> It *should* be sufficient to do it if `processLoop` at line 10632 made modifications I think
That makes more sense, I only invalidate if something changed. 


================
Comment at: llvm/test/Transforms/LoopVectorize/X86/pr59319.ll:1
+; RUN: opt -passes=loop-distribute,loop-vectorize -enable-loop-distribute -S \
+; RUN: %s | FileCheck %s
----------------
Ok, moved to the x86 directory, thanks for pointing that out. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139601/new/

https://reviews.llvm.org/D139601



More information about the llvm-commits mailing list