[PATCH] D139663: Emit unwind information in the .debug_frame section when the .cfi_sections .debug_frame directive is used.

[Shubham Sandeep Rastogi via Phabricator via llvm-commits]

rastogishubham added a comment.

@glandium Yes you are right, those are the same issues that we saw.



================
Comment at: llvm/test/DebugInfo/debugframeinfo.s:2
+# RUN: llvm-mc -filetype=obj %s -o %t.o
+# RUN: llvm-dwarfdump -debug-frame %t.o | FileCheck %s
+
----------------
aprantl wrote:
> You need to restrict this testcase to some specific architecture or check less specific things. For example, there are AArch64 register names in the CHECK output.
> 
> Generally, you just want to test that it is emitted at all, so checking just that any contents exists in the section should be enough, right?
How does it look now?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139663/new/

https://reviews.llvm.org/D139663